From 26e12b7e4fab4ba3c003cc37954bdc79a0be4476 Mon Sep 17 00:00:00 2001
From: liyongde <1419499670@qq.com>
Date: Wed, 10 May 2023 16:00:52 +0800
Subject: [PATCH] =?UTF-8?q?fix:=20=E4=BF=AE=E5=A4=8D=E8=8F=9C=E5=8D=95?=
 =?UTF-8?q?=E4=BF=AE=E6=94=B9=E9=97=AE=E9=A2=98?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../org/nl/system/service/menu/impl/SysMenuServiceImpl.java  | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/nladmin-system/nlsso-server/src/main/java/org/nl/system/service/menu/impl/SysMenuServiceImpl.java b/nladmin-system/nlsso-server/src/main/java/org/nl/system/service/menu/impl/SysMenuServiceImpl.java
index 26040c6..d29e0d6 100644
--- a/nladmin-system/nlsso-server/src/main/java/org/nl/system/service/menu/impl/SysMenuServiceImpl.java
+++ b/nladmin-system/nlsso-server/src/main/java/org/nl/system/service/menu/impl/SysMenuServiceImpl.java
@@ -190,8 +190,9 @@ public class SysMenuServiceImpl extends ServiceImpl<SysMenuMapper, SysMenu> impl
     public void update(SysMenu resources) {
         String menuId = resources.getMenu_id();
         SysMenu menu = baseMapper.selectById(menuId);
-        List<String> allChildIds = Arrays.asList(baseMapper.findAllChild(menuId).split(","));
-        if (allChildIds.contains(resources.getPid())){
+        String allChild = baseMapper.findAllChild(menuId); // 获取当前菜单的所有子菜单
+        List<String> allChildIds = ObjectUtil.isNotEmpty(allChild)?Arrays.asList(allChild.split(",")):null;
+        if (ObjectUtil.isNotEmpty(allChildIds) && allChildIds.contains(resources.getPid())){
             throw new BadRequestException("上级不能为自己或自己的下级");
         }
         if (resources.getIframe()) {